Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be more specific about glibc on backtrace functionality #17

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

Piraty
Copy link
Contributor

@Piraty Piraty commented Jan 23, 2018

other libc implementations like musl libc don't provide execinfo nor
backtrace functionality.

sources:

@sunderme
Copy link
Member

sunderme commented Jan 23, 2018

you patch breaks compilation on linux (see travis-ci).
Please fix it first !!!

other libc implementations like musl libc don't provide execinfo nor
backtrace functionality.

sources:
(fail logs on a build against musl)
http://www.openwall.com/lists/musl/2015/04/09/3
@Piraty Piraty force-pushed the backtrace-only-glibc branch from bf02177 to d16deb0 Compare January 23, 2018 17:26
@Piraty
Copy link
Contributor Author

Piraty commented Jan 23, 2018

yep, my fault. this should do it.
good thing you guys have travis now.

@sunderme
Copy link
Member

@benito: any comments ?

@Piraty
Copy link
Contributor Author

Piraty commented Jan 24, 2018

We were at this before, see here and here.
Checking for __GLIBC__ macro is what most devs do to ensure glibc specific stuff is there.

@sunderme sunderme merged commit deac6ea into texstudio-org:master Jan 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants