-
Notifications
You must be signed in to change notification settings - Fork 43
Conversation
store, unstore, storeThread, unstoreThread, deliverMessage
Moving this original info to a comment: The general idea here is to expose the Major ideas:
Some ongoing notes here, just c/p'd from
|
This is ready for a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love all the tests! While obviously none of the new endpoints are helpful to a local node (say via cli client), what do you think about exposing some of these new API endpoints in js-http-client
? Do you think some of these could be precursors to a 'lite' browser client?
v0.POST("/service", c.service) | ||
} | ||
|
||
// v1 routes | ||
v1 := router.Group("/api/v1") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool!
// v1 routes | ||
v1 := router.Group("/api/v1") | ||
|
||
store := v1.Group("/store", c.validateToken) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nice, that's slick
Thanks @carsonfarmer! Yeah, seems like having a JS client for the cafe would be slick. If you could somehow obtain a cafe session in the browser, you'd be off to the races. |
Debug bool | ||
RepoPath string | ||
Debug bool | ||
CafeOutboxHandler core.CafeOutboxHandler |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok so CafeOutboxHandler
just specifies that the object needs to implement Flush()
... Is the idea that Flush
will be called whenever new CafeRequest
s are added to the queue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, exactly.
Just pushed this guy: 6fb1e29 Need to include the core package with |
Fixes #591
Fixes #661