Skip to content

Commit

Permalink
bugfix module string includes with urlpatterns #157
Browse files Browse the repository at this point in the history
  • Loading branch information
tfranzel committed Sep 25, 2020
1 parent 390d3b5 commit 63082ef
Showing 2 changed files with 11 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drf_spectacular/plumbing.py
Original file line number Diff line number Diff line change
@@ -675,7 +675,7 @@ def detype_pattern(pattern):
if isinstance(pattern, URLResolver):
return URLResolver(
pattern=detype_pattern(pattern.pattern),
urlconf_name=[detype_pattern(p) for p in pattern.urlconf_name],
urlconf_name=[detype_pattern(p) for p in pattern.url_patterns],
default_kwargs=pattern.default_kwargs,
app_name=pattern.app_name,
namespace=pattern.namespace,
11 changes: 10 additions & 1 deletion tests/test_plumbing.py
Original file line number Diff line number Diff line change
@@ -1,8 +1,11 @@
from django.conf.urls import include, url
from django.db import models
from rest_framework import serializers

from drf_spectacular.openapi import AutoSchema
from drf_spectacular.plumbing import follow_field_source, force_instance, is_field, is_serializer
from drf_spectacular.plumbing import (
detype_pattern, follow_field_source, force_instance, is_field, is_serializer,
)


def test_is_serializer():
@@ -59,3 +62,9 @@ class FFS3(models.Model):
assert auto_schema._map_model_field(reverse_field, None)['type'] == 'number'
assert auto_schema._map_model_field(forward_model, None)['type'] == 'integer'
assert auto_schema._map_model_field(reverse_model, None)['type'] == 'integer'


def test_detype_patterns_with_module_includes(no_warnings):
detype_pattern(
pattern=url(r'^', include('tests.test_fields'))
)

0 comments on commit 63082ef

Please sign in to comment.