Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore merge cell count #652

Merged
merged 1 commit into from
Aug 22, 2022
Merged

Ignore merge cell count #652

merged 1 commit into from
Aug 22, 2022

Conversation

tfussell
Copy link
Owner

Previously my philosophy had been to do what Excel does when parsing a document. Given the kinds of problems people are running into, I now think it's better to lean towards being more permissive with parsing. For this reason, I'm removing the logic to check merged cell count. Also count is optional which causes problems reading worksheets from other spreadsheet software.

Fixes #640

@tfussell tfussell self-assigned this Aug 22, 2022
@tfussell tfussell merged commit fbae8cd into master Aug 22, 2022
@tfussell tfussell deleted the fix-merge-cell-count branch August 22, 2022 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

count attribute on CT_MergeCells should be optional
1 participant