Fix singular embed clearing

tfwright · Nov 13, 2023 · 2c9403d · 2c9403d
1 parent 15c3fd4
commit 2c9403d
Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/assets/js/app.js b/assets/js/app.js
@@ -56,9 +56,9 @@ Hooks.EmbedComponent = {
     });
 
     this.el.addEventListener("live_admin:embed_delete", e => {
-      e.target.nextElementSibling.remove();
+      e.target.parentElement.classList.add("hidden");
 
-      const deleteInput = e.target.previousElementSibling;
+      const deleteInput = e.target.closest(".embed__group").querySelector("input[value=\"\"]");
       deleteInput.disabled = false;
       deleteInput.dispatchEvent(new Event("input", {bubbles: true, cancelable: true}));
     });

diff --git a/dist/js/app.js b/dist/js/app.js
diff --git a/lib/live_admin/components.ex b/lib/live_admin/components.ex
@@ -71,7 +71,6 @@ defmodule LiveAdmin.Components do
                 />
               <% end %>
             <% else %>
-              <input type="hidden" name={input_name(@form, @field)} value="" disabled />
               <a href="#" class="button__remove" phx-click={JS.dispatch("live_admin:embed_delete")} />
             <% end %>
             <div>
@@ -100,6 +99,9 @@ defmodule LiveAdmin.Components do
           />
           <a href="#" phx-click={JS.dispatch("live_admin:embed_add")} class="button__add" />
         <% end %>
+        <%= if match?({_, _, %{cardinality: :one}}, @type) do %>
+          <input type="hidden" name={input_name(@form, @field)} value="" disabled={!!input_value(@form, @field)} />
+        <% end %>
       <% else %>
         <pre><%= @form |> input_value(@field) |> inspect() %></pre>
       <% end %>