Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch over from libgit2 to gix for git.rs #127

Closed
wants to merge 10 commits into from
Closed

Switch over from libgit2 to gix for git.rs #127

wants to merge 10 commits into from

Conversation

ZeWaka
Copy link
Collaborator

@ZeWaka ZeWaka commented Feb 11, 2023

Removes the dependency on libgit2, switches to gitoxide/gix/git-repository instead.

rustg_git_revparse working identically, for rustg_git_revparse("HEAD") of my local:
image
rustg_git_commit_date on that same commit:
image

Advisory: This does add a lot of small internal dependencies to the git-repository crate, so the final release binary goes from 6.55MB to 7.12MB, an increase of 0.57MB.
I aim to make up this difference elsewhere (see #128, saved 1.56MB there), as I don't see any immediate ways to pare down this crate (the discover fn is in the base crate, the rest seem to be in deps we could use).

@ZeWaka ZeWaka marked this pull request as ready for review February 11, 2023 19:53
@ZeWaka ZeWaka requested a review from Mothblocks February 11, 2023 19:53
@Mothblocks
Copy link
Member

Every time you say libshit2 I have literlaly no idea what you mean and have to check

@optimumtact
Copy link
Member

, so the final release binary goes from 7.14MB to 7.55MB, an increase of 0.41MB.

literally who cares lmao I have 4 terabytes of disk space

@ZeWaka
Copy link
Collaborator Author

ZeWaka commented Feb 12, 2023

, so the final release binary goes from 7.14MB to 7.55MB, an increase of 0.41MB.

oranges: literally who cares lmao I have 4 terabytes of disk space

see:

[6:58 PM] mothblocks: make sure it doesnt bloat our file size too much
[6:58 PM] mothblocks: remembert that loading a dll contributes to the memory limit
[6:58 PM] mothblocks: which isnt as big of a deal as it used to be
[6:58 PM] mothblocks: but im sure someone willbe p issed off at me eventually about it

@Mothblocks
Copy link
Member

That was in reference to statically linking an ssl lib btw

@optimumtact
Copy link
Member

who would be pissed what a load of horse shit

@Mothblocks
Copy link
Member

Idk i just dont like getting yelled at by mso

@optimumtact
Copy link
Member

protip fo rdealing with mso just lie and say I did it

@ZeWaka
Copy link
Collaborator Author

ZeWaka commented Feb 17, 2023

need to switch to gix package name

@optimumtact
Copy link
Member

finish ur shit

@ZeWaka ZeWaka changed the title Switch over from libshit2 to gitoxide crates for git.rs Switch over from libgit2 to gix for git.rs Jun 2, 2023
@ZeWaka
Copy link
Collaborator Author

ZeWaka commented Jun 2, 2023

This isn't a super big problem anymore since libgit2 doesn't require libssl1 (mysql still does unfortunately) anymore it seems. This PR could go either way.

@optimumtact
Copy link
Member

replace mysql with postgresql

@ZeWaka
Copy link
Collaborator Author

ZeWaka commented Dec 11, 2023

Closing due to redundant

@ZeWaka ZeWaka closed this Dec 11, 2023
@ZeWaka ZeWaka deleted the gitoxide branch December 11, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants