Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a null reference exception when test merging #1333

Merged
merged 1 commit into from
Sep 25, 2021
Merged

Conversation

Cyberboss
Copy link
Member

🆑
Converted a possible NullReferenceException while test merging to a proper job error.
/:cl:

@Cyberboss Cyberboss added the Fix Fixes incorrect functionality label Sep 24, 2021
@Cyberboss Cyberboss added this to the v4.14.4 milestone Sep 24, 2021
- Could happen when specifying a bad TargetCommitSha
@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #1333 (530e64a) into master (2482bcc) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
- Coverage   91.54%   91.53%   -0.01%     
==========================================
  Files         514      514              
  Lines       98675    98679       +4     
  Branches     2648     2649       +1     
==========================================
- Hits        90330    90324       -6     
- Misses       8265     8276      +11     
+ Partials       80       79       -1     

@Cyberboss Cyberboss merged commit 6ad409f into master Sep 25, 2021
@Cyberboss Cyberboss deleted the FixANullRef branch September 25, 2021 14:37
@Cyberboss Cyberboss modified the milestones: v4.14.4, v4.15.0 Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Fixes incorrect functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant