Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve logging of failed OAuth handshakes #1340

Merged
merged 14 commits into from
Oct 13, 2021
Merged

Improve logging of failed OAuth handshakes #1340

merged 14 commits into from
Oct 13, 2021

Conversation

Cyberboss
Copy link
Member

@Cyberboss Cyberboss commented Oct 8, 2021 •
edited
Loading

🆑
Failed OAuth handshakes for Discord and Keycloak now log the bodies of responses they receive from the server.
Fixed Discord channels failing to map creating an error once the instance goes offline.
Fixed issues with checkout job progress initialization.
/:cl:

@Cyberboss Cyberboss added the Logging Adding, removing, or lack of informational log output label Oct 8, 2021
@Cyberboss Cyberboss added this to the v4.15.4 milestone Oct 8, 2021
@Cyberboss Cyberboss added CI/CD IT'S NOT A PHASE MOM, IT'S A REAL SPECIALIZATION Fix Fixes incorrect functionality Release This is a release pull request labels Oct 8, 2021
@Cyberboss Cyberboss added the Area: Chat With regard to managing chat bots label Oct 9, 2021
@Cyberboss Cyberboss added the Area: Repository With regard to managing the git repository label Oct 12, 2021
@codecov
Copy link

codecov bot commented Oct 13, 2021 •
edited
Loading

Codecov Report

Merging #1340 (5c9c47a) into dev (d08719f) will decrease coverage by 0.27%.
The diff coverage is 58.10%.

@@            Coverage Diff             @@
##              dev    #1340      +/-   ##
==========================================
- Coverage   91.48%   91.20%   -0.28%     
==========================================
  Files         514      514              
  Lines       98845    98859      +14     
  Branches     2674     2680       +6     
==========================================
- Hits        90426    90169     -257     
- Misses       8338     8610     +272     
+ Partials       81       80       -1

@Cyberboss Cyberboss merged commit b3256af into dev Oct 13, 2021
@Cyberboss Cyberboss deleted the LogsLogsLogs branch October 13, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: Chat With regard to managing chat bots Area: Repository With regard to managing the git repository CI/CD IT'S NOT A PHASE MOM, IT'S A REAL SPECIALIZATION Fix Fixes incorrect functionality Logging Adding, removing, or lack of informational log output Release This is a release pull request
Projects
None yet
Milestone
v4.15.4
Development

Successfully merging this pull request may close these issues.
2 participants
@Cyberboss @tgstation-server