Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pyroclastic slime RRing ghosts #89512

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Conversation

SmArtKar
Copy link
Member

@SmArtKar SmArtKar commented Feb 16, 2025

About The Pull Request

Closes #89501

Changelog

🆑
fix: Fixed pyroclastic slime RRing ghosts
/:cl:

@github-actions github-actions bot added the Fix Rewrites a bug so it appears in different circumstances label Feb 16, 2025
@Jacquerel
Copy link
Member

Would it be insane if we moved the poll to ten seconds before the anomaly detonates so that we can apply the candidate as soon as the mob spawns?
would still need sanity checks for "did it actually blow up?" but that seems like a nicer outcome to me than the mob being ai-controlled for 10 seconds

@SmArtKar
Copy link
Member Author

Would it be insane if we moved the poll to ten seconds before the anomaly detonates so that we can apply the candidate as soon as the mob spawns? would still need sanity checks for "did it actually blow up?" but that seems like a nicer outcome to me than the mob being ai-controlled for 10 seconds

Yeah that could work

@SmArtKar SmArtKar marked this pull request as draft February 16, 2025 18:19
@SmArtKar SmArtKar marked this pull request as ready for review February 16, 2025 19:35
@Ghommie Ghommie merged commit 3f3bd5b into tgstation:master Feb 17, 2025
25 checks passed
tgstation-ci bot added a commit that referenced this pull request Feb 17, 2025
github-actions bot added a commit that referenced this pull request Feb 17, 2025
@SmArtKar SmArtKar deleted the pyroslimefix branch March 3, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix Rewrites a bug so it appears in different circumstances
Projects
None yet
Development

Successfully merging this pull request may close these issues.

accepting pyro slime can turn into a shift removal if the slime dies before you get chosen
3 participants