allows some events from modal #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for contributing to tgui-core! The workflow 'Chromatic Security' requires repository secrets and will not run without approval. Maintainers can add the |
jlsnow301
reviewed
Jan 24, 2025
|
i'm not sure what's going on with chromatic atp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Allows us to forward the escape and enter events from modal windows. This will allow for example text inputs used within a modal to be confirmed with enter or close with escape instead of needing to press any button.
Why's this needed?
We've quite a few modal inputs in use, where input fields are generated dynamically.