Fix Button
ellipsis & Stack.Item
overgrowing
#79
Merged
+42
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Fixes buttons ellipsis with icon #78
Also, ellipsis now works inside Stack.Item, for example:
It will work as it should and text inside the button will be properly cuted, IF you set
grow
prop.What about Stack.Item overgrowing? Well...
I set the minimum height and width of Stack.Item with grow to zero, so it can now shrink and fill ONLY the available space. Although I'm sure that in some situations it can still go beyond the allowed space. Let's hope I don't accidentally break one of the hundreds of UI's.
Video
chrome_tPp1laacmt.mp4
Why's this needed?
Little more flexible Stack and proper button ellipsis