Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Button ellipsis & Stack.Item overgrowing #79

Merged
merged 4 commits into from
Jan 31, 2025

Conversation

AyIong
Copy link
Contributor

@AyIong AyIong commented Jan 31, 2025

About the PR

Fixes buttons ellipsis with icon #78
Also, ellipsis now works inside Stack.Item, for example:

<Stack fill>
  <Stack.Item grow>
    <Button fluid ellipsis />
  </Stack.Item>
</Stack>

It will work as it should and text inside the button will be properly cuted, IF you set grow prop.

What about Stack.Item overgrowing? Well...
I set the minimum height and width of Stack.Item with grow to zero, so it can now shrink and fill ONLY the available space. Although I'm sure that in some situations it can still go beyond the allowed space. Let's hope I don't accidentally break one of the hundreds of UI's.

Video
chrome_tPp1laacmt.mp4

Why's this needed?

Little more flexible Stack and proper button ellipsis

@tgstation-ci
Copy link

tgstation-ci bot commented Jan 31, 2025

Thank you for contributing to tgui-core! The workflow 'Chromatic Security' requires repository secrets and will not run without approval. Maintainers can add the CI Cleared label to allow it to run. Note that any changes to chromaitc-security.yml and chromatic.yml will not be reflected.

@AyIong AyIong changed the title Fix Button ellipsis & Stack overgrowing Fix Button ellipsis & Stack.Item overgrowing Jan 31, 2025
@AyIong
Copy link
Contributor Author

AyIong commented Jan 31, 2025

Thank you for contributing to tgui-core! The workflow 'Chromatic Security' requires repository secrets and will not run without approval. Maintainers can add the CI Cleared label to allow it to run. Note that any changes to chromaitc-security.yml and chromatic.yml will not be reflected.

576908031019843604

@jlsnow301 jlsnow301 merged commit ed8a11e into tgstation:main Jan 31, 2025
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants