Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[downloader] plugin overhaul #1054

Merged
merged 22 commits into from
Mar 19, 2023
Merged

[downloader] plugin overhaul #1054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
b6f9404
download using youtubei,js instead of ytdl-core
Araxeus Mar 3, 2023
ec61071
remove `node-id3`
Araxeus Mar 3, 2023
54d3f92
add trackId to album downloads
Araxeus Mar 3, 2023
099e5d8
add download feedback and progress
Araxeus Mar 4, 2023
2cbc73d
remove unused imports
Araxeus Mar 4, 2023
a31e59f
fix download button showing when it shouldn't
Araxeus Mar 4, 2023
560e323
lint
Araxeus Mar 4, 2023
e4b1d38
dont add album to metadata if it's ===`N/A`
Araxeus Mar 4, 2023
a2eb3a3
helpful error when trying to download a private or "mixed for you" pl…
Araxeus Mar 4, 2023
cd41f09
fix download button not showing first time menu is opened
Araxeus Mar 4, 2023
7b3280c
add `skip existing files` option
Araxeus Mar 4, 2023
ad484ab
use centralized config
Araxeus Mar 4, 2023
6ca64d6
show ffmpeg progress
Araxeus Mar 4, 2023
c578196
lint
Araxeus Mar 5, 2023
83abbdb
add caching to getCoverBuffer
Araxeus Mar 12, 2023
b652a01
lint
Araxeus Mar 12, 2023
51871a3
catch errors in `downloadSong()`
Araxeus Mar 15, 2023
325026e
rome lint
Araxeus Mar 19, 2023
4f4372b
fix PR review comments
Araxeus Mar 19, 2023
6054011
Merge branch 'local-upstream/master' into new-downloader
Araxeus Mar 19, 2023
e8c3716
use new dynamic config
Araxeus Mar 19, 2023
5d8b04b
Merge branch 'master' into new-downloader
th-ch Mar 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ autoUpdater.autoDownload = false;
const gotTheLock = app.requestSingleInstanceLock();
if (!gotTheLock) app.exit();

app.commandLine.appendSwitch(
"js-flags",
// WebAssembly flags
"--experimental-wasm-threads"
);
app.commandLine.appendSwitch("enable-features", "SharedArrayBuffer"); // Required for downloader
app.allowRendererProcessReuse = true; // https://github.com/electron/electron/issues/18397
if (config.get("options.disableHardwareAcceleration")) {
Expand Down
4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@
"browser-id3-writer": "^4.4.0",
"butterchurn": "^2.6.7",
"butterchurn-presets": "^2.4.7",
"chokidar": "^3.5.3",
"custom-electron-prompt": "^1.5.4",
"custom-electron-titlebar": "^4.1.6",
"electron-better-web-request": "^1.0.1",
Expand All @@ -135,8 +134,7 @@
"node-fetch": "^2.6.8",
"simple-youtube-age-restriction-bypass": "https://gitpkg.now.sh/api/pkg.tgz?url=zerodytrash/Simple-YouTube-Age-Restriction-Bypass&commit=v2.5.4",
"vudio": "^2.1.1",
"youtubei.js": "^2.9.0",
"ytdl-core": "^4.11.1",
"youtubei.js": "^3.1.1",
"ytpl": "^2.3.0"
},
"devDependencies": {
Expand Down
11 changes: 0 additions & 11 deletions plugins/downloader/actions.js
View file
Open in desktop

This file was deleted.

Loading