Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impl save time ldap user #90

Merged
merged 3 commits into from
May 16, 2024

Conversation

BoolPurist
Copy link
Collaborator

@BoolPurist BoolPurist commented May 9, 2024

Added opt in feature to creation date for LDAP user
To preserve the backwards compatibility with earlier versions, this features must be opted in.

You can opt in by the following steps:

  1. Apply the changes from the file docker/bootstrap_lidfs/02_scheme_ldap_attr.ldif
  2. Set the field value "ldap_add_created_at" to true within the configuration file.
  3. Add the value "ldapAttributes" to the array value "objectclass_common" within the configuration file.

BoolPurist added 2 commits May 9, 2024 15:41
To preserve the backwards compatibility with earlier versions, this features must be opted in.

You can opt in by the following steps:

1. Apply the changes from the file docker/bootstrap_lidfs/02_scheme_ldap_attr.ldif
2. Set the field value "ldap_add_created_at" to `true` within the configuration file.
3. Add the value "ldapAttributes" to the array value "objectclass_common" within the configuration file.
@BoolPurist BoolPurist requested a review from dwgnr May 9, 2024 13:47
@BoolPurist
Copy link
Collaborator Author

Questions to @dwgnr:

  1. Do like the name "ldapAttributes" for objectclass under which "created_at" attribute is held ?
  2. Do agree with the opt in approach ? Allowing to use this tool without having this new attribute in the scheme.

Copy link
Collaborator

@dwgnr dwgnr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed

("sshPublicKey", hashset! {pubkey}),
("loginShell", hashset! {config.login_shell.as_str()}),
];
let created_at = Utc::now().to_rfc3339();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move this down

Fix: UTC time stamp creation is now only done
if add time stamp feature is toggled on
@BoolPurist BoolPurist merged commit d58b670 into th-nuernberg:main May 16, 2024
1 check passed
@BoolPurist BoolPurist deleted the impl_save_time_ldap_user branch May 16, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants