Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is based on the work already delivered by @hat .
TODO's
depends
, but the error still happens sometimes. Restarting docker -compose (docker -compose down
anddocker-compose up
) manually a second time does fix the problem..env
andconfig.json
, or allow mounting theconfig.json
file. This is especially important for the database variables (POSTGRES_DB
,POSTGRES_USER
,POSTGRES_PASSWORD
).docker-compose -f ./docker/development.docker-compose.yml up --build
in the project root to start both pyshelf and the database.The docker-compose here should only be given as an example. pyShelf should only be responsible for a pyShelf image on dockerhub. The docker-compose is normally written by the user himself, so he can decide which folder to use, which webserver, which database, etc. ... . Therefor, we should keep this as simple and generic as possible.
Example of the
docker-compose.yml
file:Example of the
.env
file: