Skip to content

Commit

Permalink
gometalinter: fix configuration
Browse files Browse the repository at this point in the history
The configuration abused "Exclude" to exclude file-paths by filtering
on the output, however, the `Skip` option was designed for that, whereas
`Exclude` is for matching warnings.

An explicit "Skip" was added for "vendor", because even though the vendor
directory should already be ignored by the linter, in some situations,
it still seemed to warn on issues, so let's explicitly ignore it.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
  • Loading branch information
thaJeztah committed Oct 24, 2019
1 parent 146d29c commit 71e525f
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions gometalinter.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,16 @@
"Vendor": true,
"Deadline": "2m",
"Sort": ["linter", "severity", "path", "line"],
"Exclude": [
"Skip": [
"cli/compose/schema/bindata.go",
"cli/command/stack/kubernetes/api/openapi",
"cli/command/stack/kubernetes/api/client",
".*generated.*",
"parameter .* always receives"
"vendor"
],
"Exclude": [
"parameter .* always receives",
"_esc(Dir|FS|FSString|FSMustString) is unused"
],
"EnableGC": true,
"Linters": {
Expand Down

0 comments on commit 71e525f

Please sign in to comment.