GetDefaultAuthConfig: fix potential panic due to unhandled error

Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah · Oct 29, 2020 · f32731f · f32731f
1 parent a0cacb0
commit f32731f
Showing 1 changed file with 5 additions and 4 deletions.
diff --git a/cli/command/registry.go b/cli/command/registry.go
@@ -93,17 +93,18 @@ func GetDefaultAuthConfig(cli Cli, checkCredStore bool, serverAddress string, is
 	if !isDefaultRegistry {
 		serverAddress = registry.ConvertToHostname(serverAddress)
 	}
-	var authconfig configtypes.AuthConfig
+	var authconfig = configtypes.AuthConfig{}
 	var err error
 	if checkCredStore {
 		authconfig, err = cli.ConfigFile().GetAuthConfig(serverAddress)
-	} else {
-		authconfig = configtypes.AuthConfig{}
+		if err != nil {
+			return nil, err
+		}
 	}
 	authconfig.ServerAddress = serverAddress
 	authconfig.IdentityToken = ""
 	res := types.AuthConfig(authconfig)
-	return &res, err
+	return &res, nil
 }
 
 // ConfigureAuth handles prompting of user's username and password if needed