Drop ellipsis dependency + avoid tidyselect deprecated syntax #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @olivroy for checking these! I'll have to time to check/merge things probably next week. Going forward, I'm planning to move to R 4.1, though. I'm going to use |
|
Sounds good! Yeah, I noticed #164, but didn't want to overstep since it was unnecessary to this PR. If you have difficulty following, and / or would like me to split this in 2 PRs, let me know! |
|
Just a reminder! |
|
@thackl I also updated action to unlock the pkgdown workflow! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase dependency on R 3.5 (due to usage of
...length(). (although 4.1 is actually required due to some usage of|>.Increased dependency on dplyr 1.1 (
relocate()is used in the code)More info https://dplyr.tidyverse.org/articles/programming.html
rlang also provides
dots_n()which can be used.Also added website to DESCRIPTION for discoverability