-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure: Add new az_tenant_id
, client_id
and client_secret
configs
#157
Azure: Add new az_tenant_id
, client_id
and client_secret
configs
#157
Conversation
2173225
to
534e3b1
Compare
6a8655d
to
41f4bec
Compare
tenant_id
and client_secret
configstenant_id
, client_id
and client_secret
configs
a95a395
to
e1a06ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
4681f61
to
def6bb7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm, just one small nit
tenant_id
, client_id
and client_secret
configsaz_tenant_id
, client_id
and client_secret
configs
9664819
to
8760e12
Compare
Signed-off-by: DylanGuedes <[email protected]>
8760e12
to
dffc903
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Changes
client_secret
,client_id
, andaz_tenant_id
az_tenant_id
,client_secret
andclient_id
are set, we use their values to generate an authentication token.Verification
I have created a unitary test locally that interacts with a valid existing Azure blob and I managed to authenticate correctly with the new method.