update tests

Signed-off-by: Ben Ye <[email protected]>
thanos-io · Jan 9, 2025 · 27d4e07 · 27d4e07
1 parent ab6b89e
commit 27d4e07
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 13 deletions.
diff --git a/go.mod b/go.mod
@@ -5,6 +5,7 @@ go 1.23.0
 require (
 	capnproto.org/go/capnp/v3 v3.0.0-alpha.30
 	cloud.google.com/go/trace v1.10.12
+	github.com/DataDog/sketches-go v1.4.6
 	github.com/GoogleCloudPlatform/opentelemetry-operations-go/exporter/trace v1.8.3
 	github.com/KimMachineGun/automemlimit v0.6.1
 	github.com/alecthomas/units v0.0.0-20240626203959-61d1e3462e30
@@ -18,7 +19,6 @@ require (
 	github.com/cortexproject/promqlsmith v0.0.0-20240506042652-6cfdd9739a5e
 	github.com/cristalhq/hedgedhttp v0.9.1
 	github.com/dustin/go-humanize v1.0.1
-	github.com/DataDog/sketches-go v1.4.6
 	github.com/efficientgo/core v1.0.0-rc.3
 	github.com/efficientgo/e2e v0.14.1-0.20230710114240-c316eb95ae5b
 	github.com/efficientgo/tools/extkingpin v0.0.0-20220817170617-6c25e3b627dd

diff --git a/pkg/compact/compact_e2e_test.go b/pkg/compact/compact_e2e_test.go
@@ -401,10 +401,12 @@ func testGroupCompactE2e(t *testing.T, mergeFunc storage.VerticalChunkSeriesMerg
 			testutil.Assert(t, len(meta.Thanos.SegmentFiles) > 0, "compacted blocks have segment files set")
 			// Only one chunk will be generated in that block, so we won't set chunk size.
 			testutil.Assert(t, meta.Thanos.IndexStats.SeriesMaxSize > 0, "compacted blocks have index stats series max size set")
+			testutil.Assert(t, meta.Thanos.IndexStats.SeriesAvgSize > 0, "compacted blocks have index stats series avg size set")
 			testutil.Assert(t, meta.Thanos.IndexStats.SeriesP90Size > 0, "compacted blocks have index stats series P90 size set")
 			testutil.Assert(t, meta.Thanos.IndexStats.SeriesP99Size > 0, "compacted blocks have index stats series P99 size set")
 			testutil.Assert(t, meta.Thanos.IndexStats.SeriesP999Size > 0, "compacted blocks have index stats series P999 size set")
 			testutil.Assert(t, meta.Thanos.IndexStats.SeriesP9999Size > 0, "compacted blocks have index stats series P9999 size set")
+			testutil.Assert(t, meta.Thanos.IndexStats.SeriesSizeStdDev > 0, "compacted blocks have index stats series size stddev set")
 		}
 	})
 }

diff --git a/pkg/store/acceptance_test.go b/pkg/store/acceptance_test.go
@@ -971,12 +971,14 @@ func TestBucketStore_Acceptance(t *testing.T) {
 					Downsample: metadata.ThanosDownsample{Resolution: 0},
 					Source:     metadata.TestSource,
 					IndexStats: metadata.IndexStats{
-						SeriesMaxSize:   stats.SeriesMaxSize,
-						SeriesP90Size:   stats.SeriesP90Size,
-						SeriesP99Size:   stats.SeriesP99Size,
-						SeriesP999Size:  stats.SeriesP999Size,
-						SeriesP9999Size: stats.SeriesP9999Size,
-						ChunkMaxSize:    stats.ChunkMaxSize,
+						SeriesMaxSize:    stats.SeriesMaxSize,
+						SeriesAvgSize:    stats.SeriesAvgSize,
+						SeriesP90Size:    stats.SeriesP90Size,
+						SeriesP99Size:    stats.SeriesP99Size,
+						SeriesP999Size:   stats.SeriesP999Size,
+						SeriesP9999Size:  stats.SeriesP9999Size,
+						SeriesSizeStdDev: stats.SeriesSizeStdDev,
+						ChunkMaxSize:     stats.ChunkMaxSize,
 					},
 				}, nil)
 				testutil.Ok(tt, err)
@@ -1123,12 +1125,14 @@ func TestProxyStoreWithTSDBSelector_Acceptance(t *testing.T) {
 					Downsample: metadata.ThanosDownsample{Resolution: 0},
 					Source:     metadata.TestSource,
 					IndexStats: metadata.IndexStats{
-						SeriesMaxSize:   stats.SeriesMaxSize,
-						SeriesP90Size:   stats.SeriesP90Size,
-						SeriesP99Size:   stats.SeriesP99Size,
-						SeriesP999Size:  stats.SeriesP999Size,
-						SeriesP9999Size: stats.SeriesP9999Size,
-						ChunkMaxSize:    stats.ChunkMaxSize,
+						SeriesMaxSize:    stats.SeriesMaxSize,
+						SeriesAvgSize:    stats.SeriesAvgSize,
+						SeriesP90Size:    stats.SeriesP90Size,
+						SeriesP99Size:    stats.SeriesP99Size,
+						SeriesP999Size:   stats.SeriesP999Size,
+						SeriesP9999Size:  stats.SeriesP9999Size,
+						SeriesSizeStdDev: stats.SeriesSizeStdDev,
+						ChunkMaxSize:     stats.ChunkMaxSize,
 					},
 				}, nil)
 				testutil.Ok(tt, err)