Review fixes

thanos-io · Dec 23, 2024 · b14bf1c · b14bf1c
1 parent 09cf97a
commit b14bf1c
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/block/fetcher.go b/pkg/block/fetcher.go
@@ -291,7 +291,7 @@ func (f *ConcurrentLister) GetActiveAndPartialBlockIDs(ctx context.Context, ch c
 	}
 	close(metaChan)
 
-	multiError = multierror.Append(eg.Wait(), multiError)
+	multiError = multierror.Append(multiError, eg.Wait())
 
 	if multiError != nil {
 		if multiErrorUnwrap, ok := err.(interface{ Unwrap() []error }); ok {
@@ -304,6 +304,9 @@ func (f *ConcurrentLister) GetActiveAndPartialBlockIDs(ctx context.Context, ch c
 			if len(errs) > 0 {
 				return nil, errs[0]
 			}
+		} else {
+			// if this occurs hashicorp/go-multierror may have been upgraded to a not backward compatible version
+			panic("BUG: multierr doesn't implement unwrap")
 		}
 	}