cleanup

Signed-off-by: Aditi Ahuja <[email protected]>
thanos-io · Jun 12, 2022 · efd413d · efd413d
1 parent c81e081
commit efd413d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 7 deletions.
diff --git a/pkg/tracing/jaeger/jaeger.go b/pkg/tracing/jaeger/jaeger.go
@@ -150,7 +150,6 @@ func NewTracer(ctx context.Context, logger log.Logger, metrics *prometheus.Regis
 		return nil, nil, err
 	}
 
-	level.Info(logger).Log("msg", "getting tracing config", cfg)
 	cfg.Headers = &jaeger.HeadersConfig{
 		JaegerDebugHeader: strings.ToLower(tracing.ForceTracingBaggageKey),
 	}
@@ -165,12 +164,6 @@ func NewTracer(ctx context.Context, logger log.Logger, metrics *prometheus.Regis
 		return nil, nil, err
 	}
 
-	exp, err := otel_jaeger.New(otel_jaeger.WithCollectorEndpoint())
-	if err != nil {
-		return nil, nil, err
-	}
-	_ = exp
-
 	t := &Tracer{
 		jaegerTracer,
 	}

diff --git a/test/e2e/tracing_test.go b/test/e2e/tracing_test.go
@@ -44,3 +44,7 @@ func TestJaegerTracing(t *testing.T) {
 	_, err = jaeger.NewTracerProvider(ctx, logger, data)
 	testutil.Ok(t, err)
 }
+
+// TAKE YOUR TIME, UNDERSTAND THIS AND GET IT RIGHT!
+// challenge with low stakes but def a good one!
+// if this works, add tests for compact tracing too