bucket view: popup of selected block should persist

[belm0]

Thanos, Prometheus and Golang version used: v0.12.0-rc.1

What happened: Bucket view provides a popup with details of each block. However I cannot copy any of the displayed data to the clipboard because moving the mouse towards the popup window causes a different block to be selected.

What you expected to happen: If I select a block in the bucket view, the popup window should persist so that I can interact with the window (copy text, etc.).

(The UI already supports block select and deselect. Deselect is shift-mouse_down.)

[rtnpro]

I will work on this issue.

[GiedriusS]

I still haven't seen any PR about it @rtnpro or maybe I have missed it. Hopefully, we will touch upon this during GSoC when the UI of this is going to be rewritten in React.

[rtnpro]

Cool, it sounds good to fix it once in the React rewrite.

I had hit some issues during in the initial development setup, and then I got pulled by other tasks. @GiedriusS It'd be great if you could help me get my Thanos dev env working with scripts/quickstart.sh so that I can start hunting for fixing other Thanos issues.

Also, I noticed some error logs in the quickstart.sh run.

level=debug name=query-0 ts=2020-05-27T15:07:30.349188Z caller=storeset.go:331 component=storeset msg="starting updating storeAPIs" cachedStores=4
level=debug name=query-0 ts=2020-05-27T15:07:30.350146Z caller=storeset.go:334 component=storeset msg="checked requested storeAPIs" activeStores=4 cachedStores=4
level=debug name=query-1 ts=2020-05-27T15:07:30.350566Z caller=storeset.go:331 component=storeset msg="starting updating storeAPIs" cachedStores=4
level=debug name=query-1 ts=2020-05-27T15:07:30.351163Z caller=storeset.go:334 component=storeset msg="checked requested storeAPIs" activeStores=4 cachedStores=4
level=debug name=query-0 ts=2020-05-27T15:07:35.349142Z caller=storeset.go:331 component=storeset msg="starting updating storeAPIs" cachedStores=4
level=debug name=query-1 ts=2020-05-27T15:07:35.34917Z caller=storeset.go:331 component=storeset msg="starting updating storeAPIs" cachedStores=4
level=debug name=query-0 ts=2020-05-27T15:07:35.350193Z caller=storeset.go:334 component=storeset msg="checked requested storeAPIs" activeStores=4 cachedStores=4
level=debug name=query-1 ts=2020-05-27T15:07:35.350368Z caller=storeset.go:334 component=storeset msg="checked requested storeAPIs" activeStores=4 cachedStores=4
^[level=error name=query-1 ts=2020-05-27T15:07:36.346575Z caller=logger.go:22 msg="error when flushing the buffer: write udp 127.0.0.1:55178->127.0.0.1:6831: write: connection refused"
level=error name=query-0 ts=2020-05-27T15:07:36.346569Z caller=logger.go:22 msg="error when flushing the buffer: write udp 127.0.0.1:62172->127.0.0.1:6831: write: connection refused"
level=debug name=query-1 ts=2020-05-27T15:07:40.349812Z caller=storeset.go:331 component=storeset msg="starting updating storeAPIs" cachedStores=4
level=debug name=query-0 ts=2020-05-27T15:07:40.349807Z caller=storeset.go:331 component=storeset msg="starting updating storeAPIs" cachedStores=4
level=debug name=query-1 ts=2020-05-27T15:07:40.350619Z caller=storeset.go:334 component=storeset msg="checked requested storeAPIs" activeStores=4 cachedStores=4
level=debug name=query-0 ts=2020-05-27T15:07:40.350704Z caller=storeset.go:334 component=storeset msg="checked requested storeAPIs" activeStores=4 cachedStores=4```

Thanks.

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[GiedriusS]

Still valid, we should touch upon this in about a month.

[rtnpro]

@GiedriusS Is this still happening as part of the React rewrite? Or is there scope to fix it in the current version?

…

On Fri, Jun 26, 2020 at 9:53 PM Giedrius Statkevičius < ***@***.***> wrote: Still valid, we should touch upon this in about a month. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2419 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AABYSBAH4MHLSJORAJIBFVLRYTDRRANCNFSM4MGWRRBQ> .

-- Ratnadeep Debnath, https://www.waartaa.com GPG Fingerprint: A937 6DB0 91A2 3809 27B2 1C85 8145 B6DD 3CE6 14AC

[onprem]

We are going to keep this in our mind during the React rewrite, and as @GiedriusS said the rewrite can take around a month. If it's causing a major headache, I would try to fix this in the old UI if I get some free time, no promises though. Also, any help is appreciated :)

[stale]

Hello 👋 Looks like there was no activity on this issue for last 30 days.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity for next week, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[onprem]

The React UI for Block Viewer got merged in #2980 and this should be fixed. :)

[GiedriusS]

Yep, closing as fixed ❤️