Use namespace prefix on Prometheus registry

[thorfour]

Is your proposal related to a problem?

There is a current pattern to prefix all metrics with the thanos_ prefix. This is what the namespace feature of the Prometheus registry is intended for.

Describe the solution you'd like

Remove thanos_ prefixes from metrics, and add it to the registry as a namespace.

Describe alternatives you've considered

Do nothing, and continue to enforce the prefix on pull request reviews.

Additional context

I added a histogram expecting the namespace to be provided by the registry, instead it was unexpected toil during review.

[wiardvanrij]

This would be an improvement IMO. I also don't see any downsides of doing this.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[onprem]

Still valid and help wanted :)

[vanugrah]

While we're at it I think we should leverage different subsystems as opposed to prefixing metrics with query/rule/store/compact etc.

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗

[bisakhmondal]

Remove thanos_ prefixes from metrics

It's a good idea.

and add it to the registry as a namespace.

Just wondering, would having a namespace add any help? Users can always define scrape job config with job name thanos. and all the thanos specific metrics can be visualized via something like {job:"thanos"}. The client_golang library is also planning to get rid of this namespacing and subsystems in later versions. prometheus/client_golang#240 (comment)

While we're at it I think we should leverage different subsystems as opposed to prefixing metrics with query/rule/store/compact etc.

We can use this to auto inject the prefix https://pkg.go.dev/github.com/prometheus/client_golang/prometheus#WrapRegistererWithPrefix

Let me know, what do you think. I'd love to work on this issue : )

[stale]

Hello 👋 Looks like there was no activity on this issue for the last two months.
Do you mind updating us on the status? Is this still reproducible or needed? If yes, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next two weeks, this issue will be closed (we can always reopen an issue if we need!). Alternatively, use remind command if you wish to be reminded at some point in future.