Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: range query histogram #4019

Merged
merged 5 commits into from
Apr 7, 2021
Merged

Conversation

thorfour
Copy link
Contributor

@thorfour thorfour commented Apr 4, 2021

Adds a range query histogram that tracks the distribution
of range queries. This can be useful for determining storage
retention requirements.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Adds a range query histogram to the query component.

Verification

@thorfour thorfour force-pushed the query-range-histogram branch from c189063 to 48bf7b9 Compare April 4, 2021 20:41
thorfour added 2 commits April 4, 2021 16:09
Adds a range query histogram that tracks the distribution
of range queries. This can be useful for determining storage
retention requirements.

Signed-off-by: Thor <[email protected]>
Signed-off-by: Thor <[email protected]>
@thorfour thorfour force-pushed the query-range-histogram branch from 11efdf3 to 42c2f6e Compare April 4, 2021 21:09
Signed-off-by: Thor <[email protected]>
@thorfour thorfour force-pushed the query-range-histogram branch from 42c2f6e to 6e430e3 Compare April 4, 2021 21:47
@thorfour thorfour changed the title range query histogram Query: range query histogram Apr 5, 2021
GiedriusS
GiedriusS previously approved these changes Apr 5, 2021
pkg/api/query/v1.go Outdated Show resolved Hide resolved
Signed-off-by: Thor <[email protected]>
@thorfour thorfour force-pushed the query-range-histogram branch from 4e39a9d to b4cf202 Compare April 5, 2021 20:37
Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit on naming, otherwise this is great!

pkg/api/query/v1.go Outdated Show resolved Hide resolved
@thorfour thorfour force-pushed the query-range-histogram branch from 60abce4 to 7302136 Compare April 6, 2021 15:04
@brancz brancz merged commit 7a5955b into thanos-io:main Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants