Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tools: bucket rewrite tool doesn't work with dry run and multiple block IDs #4713

Closed
yeya24 opened this issue Sep 30, 2021 · 3 comments
Closed

Comments

@yeya24
Copy link
Contributor

yeya24 commented Sep 30, 2021

Thanos, Prometheus and Golang version used: main

When using bucket rewrite tool with dry run mode and specifying multiple blocks, it only processes the first block and the process exits.

From the code https://github.com/thanos-io/thanos/blob/main/cmd/thanos/tools_bucket.go#L1137, it returns nil when dry run mode is enabled. It should continue execution in this case.

@4molybdenum2
Copy link
Contributor

@yeya24 made a PR. Can you check?

@yeya24
Copy link
Contributor Author

yeya24 commented Oct 1, 2021

Just to double check. For each specified block, rewrite tool will rewrite it separately. Is this intended or should it rewrite all specified blocks into a larger one?
cc @bwplotka

@yeya24
Copy link
Contributor Author

yeya24 commented Oct 16, 2021

Close this for now.

@yeya24 yeya24 closed this as completed Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants