Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bucket tools to dry run with multiple block ID's #4716

Merged
merged 1 commit into from
Oct 1, 2021
Merged

Fix bucket tools to dry run with multiple block ID's #4716

merged 1 commit into from
Oct 1, 2021

Conversation

4molybdenum2
Copy link
Contributor

Signed-off-by: 4molybdenum2 [email protected]

Fixed Bucket Tools such that it supports Dry Run with multiple block ID's (#4713)

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Changed the code such that when dry run mode is enabled for multiple id's the function doesn't return nil after first iteration of the loop and instead continues to the next iteration.
  • Updated logger to log the block ID for each such block in dry run.

@yeya24
Copy link
Contributor

yeya24 commented Sep 30, 2021

Can u remove the unrelated change of bindata?

@4molybdenum2
Copy link
Contributor Author

Yea, I just noticed...I removed them

yeya24
yeya24 approved these changes Oct 1, 2021
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM

@yeya24 yeya24 merged commit 35b88ab into thanos-io:main Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@4molybdenum2 @yeya24