downsample: Downsample requires gcs_bucket even when using S3

[jdfalk]

Thanos, Prometheus and Golang version used

docker improbable/thanos:v0.1.0-rc.2

What happened
Attempt to run thanos downsample with only s3 and thanos exits saying that the gcs_bucket hasn't been defined.

downsample --data-dir /prometheus --s3.endpoint ourserver:46214 --s3.bucket prometheus --s3.access-key stuff --log.level=debug
Error parsing commandline arguments: required flag --gcs.bucket not provided
usage: thanos downsample --gcs.bucket=<bucket> [<flags>]

What you expected to happen
Thanos downsample to run like compact minus the compact

How to reproduce it (as minimally and precisely as possible):
See command above

Environment:

• OS (e.g. from /etc/os-release): amazon linux 2
• Kernel (e.g. uname -a): 4.14.62-70.117.amzn2.x86_64

[jdfalk]

Happens even on the latest image:
Status: Downloaded newer image for improbable/thanos:master-2018-08-24-d5986d9
Error parsing commandline arguments: required flag --gcs.bucket not provided

[bwplotka]

Valid bug

[xphyr]

I have submitted #496 for this bug. It should fix this issue, however I do not have any google cloud storage to test against to verify. I also included a very small fix to the contributors guide, as the instructions for setting up the remote were backwards. ("git add remote", vs "git remote add".)

[bwplotka]

@xphyr waiting for you to rebase and feel free to update contributor guide as well. Thanks!

[xphyr]

Oh, sorry. I will rebase and resubmit. Sorry for the delay.

[jojohappy]

@bwplotka I guess this issue has been fixed with #500, could we close it?

[xjewer]

should be closed