downsample: Fix for Issue 494 #496
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #494 |
|
Please rebase this for green CI (Landed fix #504) (: Then we will sure all is working |
|
ping |
|
it will be fixed anyway by #500 |
|
but still worth to land if you want |
|
I guess it could be closed in favour of #500 has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a very simple fix for issue 494, and a small change to the Contributors instructions
Changes
Verification
I have run the test suite, but I do not have access to S3 or GCS to fully test this functionality, however I do not expect it to be an issue based on the scope of change.