Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thanos compactor upload COS bucket error #5137

Closed
wu3396 opened this issue Feb 8, 2022 · 6 comments
Closed

Thanos compactor upload COS bucket error #5137

wu3396 opened this issue Feb 8, 2022 · 6 comments

Comments

@wu3396
Copy link

wu3396 commented Feb 8, 2022

Thanos version used:

0.24

Object Storage Provider:

COS

What happened:

upload cos object error, The single object size you upload can not be larger than 5GB

What you expected to happen:

Send correct file size to support multipart uploads

Full logs to relevant components:

level=error ts=2022-02-08T01:42:36.662263384Z caller=compact.go:492 msg="retriable error" err="compaction: group 0@14527284864645982195: upload of 01FVB6MWHT2KA0KXJGT444FYBY failed: upload index: upload file /data/thanos/compact/0@14527284864645982195/01FVB6MWHT2KA0KXJGT444FYBY/index as 01FVB6MWHT2KA0KXJGT444FYBY/index: upload cos object: The single object size you upload can not be larger than 5GB"

@hanjm
Copy link
Member

hanjm commented Feb 8, 2022

Currently we use simple PUT API https://github.com/thanos-io/thanos/blob/main/pkg/objstore/cos/cos.go#L199, it has 5GB service limit , We need implement using multipart uploads API.

on the other hand, you can use flag --compact.block-max-index-size=5GB to skip compact if block-index-size large than 5GB. https://github.com/thanos-io/thanos/blob/main/cmd/thanos/compact.go#L743

@hanjm
Copy link
Member

hanjm commented Feb 9, 2022

WIP

hanjm added a commit to hanjm/thanos that referenced this issue Feb 10, 2022
hanjm added a commit to hanjm/thanos that referenced this issue Feb 10, 2022
@hanjm
Copy link
Member

hanjm commented Feb 11, 2022

Fixed by #5137, @wu3396 Could you try the latest image?

@wu3396
Copy link
Author

wu3396 commented Feb 11, 2022

The latest image runs without errors
I'm using a flag to skip compression, is it possible to remove the "no-compact-mark.json" in the object store to revalidate?

@hanjm
Copy link
Member

hanjm commented Feb 12, 2022

@wu3396 Just delete the "no-compact-mark.json" file using coscmd or cloud ui. then the compactor will process the block.

@wu3396
Copy link
Author

wu3396 commented Feb 12, 2022

@hanjm 14GB index file uploaded successfully. Thanks for the help!

@wu3396 wu3396 closed this as completed Feb 12, 2022
Nicholaswang pushed a commit to Nicholaswang/thanos that referenced this issue Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants