Changelog entry for Go MADV; doc cleanup #1178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
reviewed
May 28, 2019
GiedriusS
reviewed
May 28, 2019
GiedriusS
reviewed
May 28, 2019
CHANGELOG.md
Outdated
|
|
||
| > On Linux, the runtime now uses MADV_FREE to release unused memory. This is more efficient but may result in higher reported RSS. The kernel will reclaim the unused data when it is needed. To revert to the Go 1.11 behavior (MADV_DONTNEED), set the environment variable GODEBUG=madvdontneed=1. | ||
|
|
||
| To ensure correct memory reporting: |
There was a problem hiding this comment.
Is it really incorrect with those changes? Maybe precise would fit here more
GiedriusS
reviewed
May 28, 2019
|
PTAL @GiedriusS and thanks for review |
povilasv
requested changes
May 29, 2019
cmd/thanos/sidecar.go
Outdated
| TSDBMinTime: model.Duration(2 * time.Hour), | ||
| TSDBMaxTime: model.Duration(2 * time.Hour), | ||
| } | ||
| var ( |
There was a problem hiding this comment.
I don't think this code change should be part of this PR, or am I missing smth?
There was a problem hiding this comment.
It is intentionally there, but can split if needed
Signed-off-by: Bartek Plotka <[email protected]>
bwplotka
changed the title
|
I simplified PR with just doc and CHANGELOG change. @povilasv please read carefully.
Yes that's why I updated 0.4.0 release.
It's already there for newest unlreleased. |
|
👍 |
povilasv
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Bartek Plotka [email protected]