-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query: allow multiple deduplication label. #1362
Merged
bwplotka
merged 17 commits into
thanos-io:master
from
krasi-georgiev:multi-dedup-labels
Sep 16, 2019
Merged
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
bf4cdf3
allow multiple deduplication label.
krasi-georgiev 0837d37
changelog
krasi-georgiev 6ded7be
docs
krasi-georgiev afac811
bug in the replicate labels stripping
krasi-georgiev 01d227d
extended the TestDedupSeriesSet with multi replica labels.
krasi-georgiev a35f320
docs update
krasi-georgiev d8d83e0
added replicaLabels to api
krasi-georgiev 707eca9
updated docs for the API replica labels.
krasi-georgiev bcc6d9d
Merge remote-tracking branch 'upstream/master' into multi-dedup-labels
krasi-georgiev fccf8c8
missing dedup label from some series
krasi-georgiev ae7faf1
nice review changes
krasi-georgiev 35ac58b
Merge remote-tracking branch 'upstream/master' into multi-dedup-labels
krasi-georgiev 841b889
nits
krasi-georgiev b292897
replicaLabels typo
krasi-georgiev b85ce29
Merge remote-tracking branch 'upstream/master' into multi-dedup-labels
krasi-georgiev 5c4ae8c
added api replica tests
krasi-georgiev b8cd889
use tsdb storage package for the proxy
krasi-georgiev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you mean to put this below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway I would be fine with just what we have in doc, so maybe we can drop this comment?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No this is the right place and it is for the
partialResponseParam
I prefer to keep the comment here as I was a bit confused why this is done this way when I first saw it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why you put it here then and not for
parseDownsamplingParamMillis
andparseReplicaLabelsParam
? I don't get it ):