Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nit: ensure build works when GOPATH is not set #1647

Merged
merged 1 commit into from
Oct 14, 2019
Merged

nit: ensure build works when GOPATH is not set #1647

merged 1 commit into from
Oct 14, 2019

Conversation

ppanyukov
Copy link
Contributor

ensure make build works when GOPATH is not set

  • this gets me every single time;
  • use go env GOPATH which also returns default;
  • Change is not relevant to the end user.

Changes

  • Makefile. This kind of fix is already in thanosbench repo.

Verification

Manual tests:

  • Go 1.13
  • Explicitly set GOPATH;
  • Empty GOPATH.

@bwplotka bwplotka merged commit b9101c0 into thanos-io:master Oct 14, 2019
GiedriusS pushed a commit that referenced this pull request Oct 28, 2019
@ppanyukov @GiedriusS
nit: ensure build works when GOPATH is not set (#1647)
454537e 
Signed-off-by: Philip Panyukov <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ppanyukov @bwplotka