cmd/thanos/main.go: simplify pprof registration #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simplifies the registration of pprof HTTP endpoints. The pprof.Index handler automatically takes care of delegating to the correct handler for each profile depending on the request path: https://golang.org/src/net/http/pprof/pprof.go?s=8862:9042#L260 The following profiles are handled: https://golang.org/src/net/http/pprof/pprof.go?s=7565:8570#L248 Note that this also includes the `allocs` profile, which was previously not explicitly added. Signed-off-by: Lucas Servén Marín <[email protected]>
brancz
approved these changes
Oct 21, 2019
bwplotka
approved these changes
Oct 21, 2019
bwplotka
reviewed
Oct 21, 2019
| @@ -236,10 +236,6 @@ func registerProfile(mux *http.ServeMux) { | |||
| mux.HandleFunc("/debug/pprof/profile", pprof.Profile) | |||
| mux.HandleFunc("/debug/pprof/symbol", pprof.Symbol) | |||
| mux.HandleFunc("/debug/pprof/trace", pprof.Trace) | |||
There was a problem hiding this comment.
so those are not added by index?
There was a problem hiding this comment.
ack, only the profiles accessible via pprof.Handler(...) are delegated.
GiedriusS
pushed a commit
that referenced
this pull request
Oct 28, 2019
This commit simplifies the registration of pprof HTTP endpoints. The pprof.Index handler automatically takes care of delegating to the correct handler for each profile depending on the request path: https://golang.org/src/net/http/pprof/pprof.go?s=8862:9042#L260 The following profiles are handled: https://golang.org/src/net/http/pprof/pprof.go?s=7565:8570#L248 Note that this also includes the `allocs` profile, which was previously not explicitly added. Signed-off-by: Lucas Servén Marín <[email protected]> Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit simplifies the registration of pprof HTTP endpoints. The
pprof.Index handler automatically takes care of delegating to the
correct handler for each profile depending on the request path:
https://golang.org/src/net/http/pprof/pprof.go?s=8862:9042#L260
The following profiles are handled:
https://golang.org/src/net/http/pprof/pprof.go?s=7565:8570#L248
Note that this also includes the
allocsprofile, which was previouslynot explicitly added.
Signed-off-by: Lucas Servén Marín [email protected]
Verification
Built binary and verified all pprof endpoints continue to function.
cc @bwplotka