-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added official Governance page for Thanos. #1688
Conversation
All maintainers, please review and approve *only* if you agree. Signed-off-by: Bartek Plotka <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looking good to me. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few small things, but otherwise lgtm.
Signed-off-by: Bartek Plotka <[email protected]>
Thanks all for the detailed review, this should be now ready for another round. Once I have couple of approves I will send voting email to the team (: |
lgtm |
|
||
Votes may take the form of a single proposal, with the option to vote yes or no, or the form of multiple alternatives. | ||
|
||
A vote on a single proposal is considered successful if more vote in favor than against. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only (stupid) question: what if we have a even number of members and an equal amount of people vote for/against? (:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It has to be more to be successful so in that case it would be declined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will add to FAQ
docs/governance.md
Outdated
|
||
All are encourage to start their own project related to Thanos. Thanos team is happy to link to your poject in appriopriate page e.g https://thanos.io/integrations.md/ | ||
|
||
### How do I remove a Maintainer of Triage member? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
### How do I remove a Maintainer of Triage member? | |
### How do I remove a Maintainer or Triage member? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
docs/governance.md
Outdated
|
||
It's important for the project to stay independent and focused on shared interest instead of single use case of one company or organization. | ||
|
||
We value open source values and freedom, that's why we limit Maintainers Team votes to maximum two from a single organization or company. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if a good idea or not but I do not know about all the maintainers what company they work for.
Might be worth to add it to the https://thanos.io/maintainers/ so the community can see who is behind this project and in case of voting there is a place where to check the number of votes from one company?
On the other hand I'm not sure how private information this is and if anyone has issue with stating this publicly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think at least team members should be made aware, agreed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair point 👍 Will add if that's ok with the team here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though what if company has no influence on your priority? E.g they are not using Thanos and you do all just as a hobby? (: I think that's a fair point.
@thanos-io/thanos-maintainers We have some consensus here, so sent VOTE email. (: |
The vote was 100% in favor, so merging this on green. Thank you all! |
As agreed #1688 (comment) Signed-off-by: Bartek Plotka <[email protected]>
Signed-off-by: Bartek Plotka <[email protected]>
As agreed #1688 (comment) Signed-off-by: Bartek Plotka <[email protected]>
🎉 |
As per our discussion on Thanos Maintainer Sync we crafted first official Governance doc for Thanos project. Heavily based on Prometheus.
All maintainers, please read very carefully and review. Please approve only if you agree.
Vote
for this change will be send next week (: Have a nice weekend!@brancz @metalmatze @povilasv @domgreen @GiedriusS
Signed-off-by: Bartek Plotka [email protected]