Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added official Governance page for Thanos. #1688

Merged
merged 3 commits into from
Nov 1, 2019
Merged

Added official Governance page for Thanos. #1688

merged 3 commits into from
Nov 1, 2019

Conversation

bwplotka
Copy link
Member

As per our discussion on Thanos Maintainer Sync we crafted first official Governance doc for Thanos project. Heavily based on Prometheus.

All maintainers, please read very carefully and review. Please approve only if you agree.

Vote for this change will be send next week (: Have a nice weekend!

@brancz @metalmatze @povilasv @domgreen @GiedriusS

Signed-off-by: Bartek Plotka [email protected]

All maintainers, please review and approve *only* if you agree.

Signed-off-by: Bartek Plotka <[email protected]>
Copy link
Contributor

@metalmatze metalmatze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looking good to me. :)

Copy link
Member

@brancz brancz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few small things, but otherwise lgtm.

docs/governance.md Outdated Show resolved Hide resolved
docs/governance.md Outdated Show resolved Hide resolved
docs/governance.md Outdated Show resolved Hide resolved
docs/governance.md Outdated Show resolved Hide resolved
docs/governance.md Outdated Show resolved Hide resolved
docs/governance.md Outdated Show resolved Hide resolved
docs/governance.md Outdated Show resolved Hide resolved
docs/governance.md Outdated Show resolved Hide resolved
docs/governance.md Outdated Show resolved Hide resolved
docs/governance.md Outdated Show resolved Hide resolved
Signed-off-by: Bartek Plotka <[email protected]>
@bwplotka
Copy link
Member Author

Thanks all for the detailed review, this should be now ready for another round.

Once I have couple of approves I will send voting email to the team (:

@bwplotka bwplotka requested review from metalmatze, GiedriusS, brancz and jojohappy and removed request for metalmatze October 29, 2019 12:26
@brancz
Copy link
Member

brancz commented Oct 29, 2019

lgtm


Votes may take the form of a single proposal, with the option to vote yes or no, or the form of multiple alternatives.

A vote on a single proposal is considered successful if more vote in favor than against.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only (stupid) question: what if we have a even number of members and an equal amount of people vote for/against? (:

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has to be more to be successful so in that case it would be declined.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will add to FAQ


All are encourage to start their own project related to Thanos. Thanos team is happy to link to your poject in appriopriate page e.g https://thanos.io/integrations.md/

### How do I remove a Maintainer of Triage member?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### How do I remove a Maintainer of Triage member?
### How do I remove a Maintainer or Triage member?

Copy link
Member

@jojohappy jojohappy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍


It's important for the project to stay independent and focused on shared interest instead of single use case of one company or organization.

We value open source values and freedom, that's why we limit Maintainers Team votes to maximum two from a single organization or company.
Copy link
Member

@FUSAKLA FUSAKLA Oct 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if a good idea or not but I do not know about all the maintainers what company they work for.
Might be worth to add it to the https://thanos.io/maintainers/ so the community can see who is behind this project and in case of voting there is a place where to check the number of votes from one company?

On the other hand I'm not sure how private information this is and if anyone has issue with stating this publicly.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at least team members should be made aware, agreed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair point 👍 Will add if that's ok with the team here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though what if company has no influence on your priority? E.g they are not using Thanos and you do all just as a hobby? (: I think that's a fair point.

@bwplotka
Copy link
Member Author

bwplotka commented Oct 30, 2019

@thanos-io/thanos-maintainers We have some consensus here, so sent VOTE email. (:

@bwplotka
Copy link
Member Author

bwplotka commented Nov 1, 2019

The vote was 100% in favor, so merging this on green. Thank you all!

bwplotka added a commit that referenced this pull request Nov 1, 2019
bwplotka added a commit that referenced this pull request Nov 1, 2019
@bwplotka bwplotka merged commit c7e787d into master Nov 1, 2019
@bwplotka bwplotka deleted the governance branch November 1, 2019 11:20
@bwplotka
Copy link
Member Author

bwplotka commented Nov 1, 2019

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants