Code

Add query memory limits#1747

Code

Closed

ppanyukov wants to merge 17 commits intothanos-io:masterthanos-io/thanos:masterfrom ppanyukov:feature/CDATA-1163-query-limitsppanyukov/thanos:feature/CDATA-1163-query-limitsCopy head branch name to clipboard

+334-4

Commits

Commits on Nov 21, 2019

• instrument SG and Querier

  Show description for 936179c
  ppanyukov

  committed
  936179c

  Copy full SHA for 936179c

• implement query limits in Q and SG

  Show description for fadf0ae
  ppanyukov

  committed
  fadf0ae

  Copy full SHA for fadf0ae

• goimiports

  Show description for d686407
  ppanyukov

  committed
  d686407

  Copy full SHA for d686407

• Print messages to stderr in limit.go

  Show description for 84ac471
  ppanyukov

  committed
  84ac471

  Copy full SHA for 84ac471

• don't write pprof dump files

  Show description for aa3f47d
  ppanyukov

  committed
  aa3f47d

  Copy full SHA for aa3f47d

• fix deadlock due to instrumention

  Show description for a6de556
  ppanyukov

  committed
  a6de556

  Copy full SHA for a6de556

• remove instrumentation

  Show description for 25ac1ab
  ppanyukov

  committed
  25ac1ab

  Copy full SHA for 25ac1ab

• buffer atomic counters

  Show description for ed68748
  ppanyukov

  committed
  ed68748

  Copy full SHA for ed68748

• faster query sizing in SG by using approximations

  Show description for 47a3d86
  ppanyukov

  committed
  47a3d86

  Copy full SHA for 47a3d86

• manually inline frameSize func in proxy.go

  Show description for 1c0210d
  ppanyukov

  committed
  1c0210d

  Copy full SHA for 1c0210d

• better addAndCheck func for query limiters

  Show description for 34c9010
  ppanyukov

  committed
  34c9010

  Copy full SHA for 34c9010

• remove useless atomic load

  Show description for 5d2a366
  ppanyukov

  committed
  5d2a366

  Copy full SHA for 5d2a366

• remove all printing using fmt package, replace with logger

  Show description for c960b7b
  ppanyukov

  committed
  c960b7b

  Copy full SHA for c960b7b

• tidy up diffs

  Show description for 2ecd97e
  ppanyukov

  committed
  2ecd97e

  Copy full SHA for 2ecd97e

• fix dumb nil pointer dereference

  Show description for c8bcce9
  ppanyukov

  committed
  c8bcce9

  Copy full SHA for c8bcce9

• print debug log message when query limit is exceeded

  Show description for 17ce652
  ppanyukov

  committed
  17ce652

  Copy full SHA for 17ce652

Commits on Nov 23, 2019

• Expose PromQL samples limit via THANOS_LIMIT_PROMQL_MAX_SAMPLES env var

  Show description for b228521
  ppanyukov

  committed
  b228521

  Copy full SHA for b228521