objstore: add ObjectSize() implementation #1792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new method ObjectSize(context.Context, string) method to our object storage interface which returns the size of the specified object in uint64 without actually downloading all of it. This is a pre-requisite to one check that we want to add. Add a check to our E2E tests to see if it works. Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
bwplotka
approved these changes
Nov 26, 2019
| @@ -42,6 +42,11 @@ func TestObjStore_AcceptanceTest_e2e(t *testing.T) { | |||
| testutil.Ok(t, err) | |||
| testutil.Equals(t, "@test-data@", string(content)) | |||
|
|
|||
| // Check if we can get the correct size. | |||
There was a problem hiding this comment.
Can we check if ObjectSize for non existing block properly errors? Also if we can find assert NotFound on such operation if block is missing? The latter is not critical, but if we cannot assume so, we should document that as a method comment (:
There was a problem hiding this comment.
Added a test for this before the initial upload and cleaned up the functions so that IsObjNotFoundErr(error) would be properly triggered in such cases.
The exact error is needed by the callers so that they could check `IsObjNotFoundErr` correctly. Add a test for this to the E2E tests. Signed-off-by: Giedrius Statkevičius <[email protected]>
Signed-off-by: Giedrius Statkevičius <[email protected]>
|
Merging this as I have addressed the comments and since it doesn't change the behaviour in any way ATM. Will rebase #1550 on these methods now. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new method ObjectSize(context.Context, string) method to our
object storage interface which returns the size of the specified object
in uint64 without actually downloading all of it.
This is a pre-requisite to one check that we want to add (#1550).
Add a check to our E2E tests to see if it works.
Signed-off-by: Giedrius Statkevičius [email protected]