Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix wrong defalut value #1858

Merged
merged 3 commits into from
Dec 13, 2019
Merged

fix wrong defalut value #1858

merged 3 commits into from
Dec 13, 2019
+3 −3

Conversation

daixiang0
Copy link
Member

Signed-off-by: Xiang Dai [email protected]

Refer to CHANGELOG.md:376:

- [#970](https://github.com/thanos-io/thanos/pull/970) Deprecated `partial_response_disabled` proto field. Added `partial_response_strategy` instead. Both in gRPC and Query API.
  No `PartialResponseStrategy` field for `RuleGroups` by default means `abort` strategy (old PartialResponse disabled) as this is recommended option for Rules and alerts.

@daixiang0
fix wrong defalut value

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1229ced 
Signed-off-by: Xiang Dai <[email protected]>
GiedriusS
GiedriusS reviewed Dec 11, 2019
View reviewed changes
GiedriusS
GiedriusS reviewed Dec 11, 2019
View reviewed changes
@daixiang0
fix nits
caacef1 
Signed-off-by: Xiang Dai <[email protected]>
@daixiang0 daixiang0 requested a review from GiedriusS December 12, 2019 01:56
bwplotka
bwplotka approved these changes Dec 13, 2019
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(: .. and LGTM

@daixiang0
fix a typo
7e90080 
Signed-off-by: Xiang Dai <[email protected]>
@squat squat merged commit 3f9aa12 into thanos-io:master Dec 13, 2019
@daixiang0 daixiang0 deleted the default branch December 13, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka

@GiedriusS GiedriusS

Assignees
No one assigned
Labels
component: website/docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@daixiang0 @GiedriusS @bwplotka @squat