Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up white noise and format all codes #1876

Merged
merged 1 commit into from
Dec 16, 2019

Conversation

daixiang0
Copy link
Member

@daixiang0 daixiang0 commented Dec 12, 2019

Signed-off-by: Xiang Dai [email protected]

Based on #1801, finish format and lint for current codes and docs.

Changes

  • clean up all white noise calling make docs
  • fix comment issue calling make format:
>> checking Go comments trailing periods


./pkg/objstore/oss/oss.go:
func (b *Bucket) ObjectSize(ctx context.Context, name string) (uint64, error) {
	// https://github.com/aliyun/aliyun-oss-go-sdk/blob/cee409f5b4d75d7ad077cacb7e6f4590a7f2e172/oss/bucket.go#L668
	m, err := b.bucket.GetObjectMeta(name)




 Error: Found comments without trailing period. Comments has to be full sentences.

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm.. does it mean that our CI does not find those mistakes? 🤔

@daixiang0
Copy link
Member Author

daixiang0 commented Dec 13, 2019

Yep, i run those cmd by hand then fix them.
The white noise is introduced by the PR merge at same time, so need to clean up here.
I think this go file never changed since CI enable.

@daixiang0 daixiang0 requested a review from bwplotka December 13, 2019 02:06
@bwplotka bwplotka merged commit 2f29975 into thanos-io:master Dec 16, 2019
@daixiang0 daixiang0 deleted the cleanup branch December 16, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants