sidecar: don't require Prometheus min/max block durations to be equal #1902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstyan
force-pushed
the
sidecar-unequal-block
branch
from
2fc4b10 to
331ec7f
Compare
gouthamve
approved these changes
Dec 17, 2019
bwplotka
approved these changes
Dec 17, 2019
cmd/thanos/sidecar.go
Outdated
| @@ -60,6 +60,8 @@ func registerSidecar(m map[string]setupFunc, app *kingpin.Application) { | |||
|
|
|||
| uploadCompacted := cmd.Flag("shipper.upload-compacted", "If true sidecar will try to upload compacted blocks as well. Useful for migration purposes. Works only if compaction is disabled on Prometheus. Do it once and then disable the flag when done.").Default("false").Bool() | |||
|
|
|||
| ignoreBlockSize := cmd.Flag("shipper.ignore-unequal-block-size", "If true sidecar will not require prometheus min and max block size flags to be set to the same value. Only use this if you want to keep long retention and compaction enabled on your Prometheus instance, as in the worst case it can result in ~2h data loss for your Thanos bucket storage.").Default("false").Bool() | |||
There was a problem hiding this comment.
Let's make it .Hidden() for now and not put in CHANGELOG (:
There was a problem hiding this comment.
I also removed it from docs/components/sidecar.md
user passes a flag. Signed-off-by: Callum Styan <[email protected]>
cstyan
force-pushed
the
sidecar-unequal-block
branch
from
331ec7f to
9d9db25
Compare
bwplotka
approved these changes
Dec 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bwplotka
Adds a flag that allows users to disable the requirement that their Prometheus instances have equal min/max block durations if they have enabled block upload.
As discussed on slack; because only uncompacted blocks are uploaded, in the event of an upload failure or network issues that last longer than 4h there is the potential for data loss (in the bucket storage) if blocks are compacted by Prometheus during that time
Signed-off-by: Callum Styan [email protected]
cc @gouthamve @beorn7