Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment all log format #2000

Merged
merged 1 commit into from
Feb 6, 2020
Merged

comment all log format #2000

merged 1 commit into from
Feb 6, 2020

Conversation

daixiang0
Copy link
Member

Signed-off-by: Xiang Dai [email protected]

@daixiang0
Copy link
Member Author

@FUSAKLA mind have a look?

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Let's make it more verbose, otherwise LGTM

cmd/thanos/main.go Outdated Show resolved Hide resolved
Copy link
Member

@FUSAKLA FUSAKLA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for @bwplotka suggestion, otherwise ok from me 👍

Signed-off-by: Xiang Dai <[email protected]>
Signed-off-by: Xiang Dai <[email protected]>
@bwplotka bwplotka merged commit 1b22a17 into thanos-io:master Feb 6, 2020
@daixiang0 daixiang0 deleted the fmt branch February 7, 2020 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants