Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't calculate compact group key multiple times #2044

Merged
merged 1 commit into from
Jan 26, 2020
Merged

Don't calculate compact group key multiple times #2044

merged 1 commit into from
Jan 26, 2020

Conversation

yeya24
Copy link
Contributor

@yeya24 yeya24 commented Jan 25, 2020

Signed-off-by: yeya24 [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Use a variable to keep the group key instead of calculating it multiple times

Verification

bwplotka
bwplotka approved these changes Jan 26, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair 👍

Thanks! LGTM 👍

@bwplotka bwplotka merged commit e1ae2be into thanos-io:master Jan 26, 2020
@yeya24 yeya24 deleted the dont-repeated-calculate-groupkey branch January 26, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yeya24 @bwplotka