Added Copyright header to all Go and Proto source files. #2063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
force-pushed
the
add-copyright
branch
from
b06b5ee to
733cf25
Compare
squat
reviewed
Jan 28, 2020
| @@ -1,3 +1,6 @@ | |||
| // Copyright (c) The Thanos Authors. | |||
| // Licensed under the Apache License 2.0. | |||
|
|
|||
| // +build !linux | |||
There was a problem hiding this comment.
This is causing format errors in the file now :///
>> checking Go comments trailing periods
./pkg/testutil/sysprocattr.go:
// Licensed under the Apache License 2.0.
// +build !linux
package testutil
Error: Found comments without trailing period. Comments has to be full sentences.
make: *** [Makefile:195: check-comments] Error 1
bwplotka
force-pushed
the
add-copyright
branch
from
733cf25 to
fdd2291
Compare
|
PTAL @squat |
As per: https://github.com/cncf/foundation/blob/master/copyright-notices.md#copyright-notices Signed-off-by: Bartlomiej Plotka <[email protected]>
As per: https://github.com/cncf/foundation/blob/master/copyright-notices.md#copyright-notices Signed-off-by: Bartlomiej Plotka <[email protected]>
bwplotka
force-pushed
the
add-copyright
branch
from
fdd2291 to
b3c721a
Compare
squat
approved these changes
Jan 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per: https://github.com/cncf/foundation/blob/master/copyright-notices.md#copyright-notices
Signed-off-by: Bartlomiej Plotka [email protected]