Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: optimize jsonnet-format target #2076

Merged
merged 1 commit into from
Jan 29, 2020

Conversation

daixiang0
Copy link
Member

@daixiang0 daixiang0 commented Jan 29, 2020

Signed-off-by: Xiang Dai [email protected]

Fix following error:

# make examples
find . -name 'vendor' -prune -o -name '*.libsonnet' -print -o -name '*.jsonnet' -print | \
	xargs -n 1 -- jsonnetfmt -n 2 --max-blank-lines 2 --string-style s --comment-style s -i
xargs: jsonnetfmt: No such file or directory

Makefile Outdated Show resolved Hide resolved
@daixiang0 daixiang0 changed the title Makefile: install josonnet before do jsonnet format [Draft] Makefile: install josonnet before do jsonnet format Jan 29, 2020
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for this inconvenience, I've forgotten this bit.
I've already fixed this, in one of our projects so have a look at it.

https://github.com/observatorium/observatorium/blob/master/Makefile

Makefile Outdated Show resolved Hide resolved
Makefile Show resolved Hide resolved
@daixiang0 daixiang0 changed the title [Draft] Makefile: install josonnet before do jsonnet format Makefile: optiomize jsonnet-format targe Jan 29, 2020
@daixiang0 daixiang0 requested a review from squat January 29, 2020 11:28
@daixiang0 daixiang0 changed the title Makefile: optiomize jsonnet-format targe Makefile: optiomize jsonnet-format target Jan 29, 2020
@daixiang0
Copy link
Member Author

Since even we download binary, it may not work as expected, i would check the cmd and comment here.

@brancz brancz changed the title Makefile: optiomize jsonnet-format target Makefile: optimize jsonnet-format target Jan 29, 2020
@squat squat merged commit 63ec1c5 into thanos-io:master Jan 29, 2020
@daixiang0 daixiang0 deleted the install-jmt branch January 30, 2020 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants