Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make: Fix broken make task #2132

Merged
merged 1 commit into from
Feb 13, 2020
Merged

make: Fix broken make task #2132

merged 1 commit into from
Feb 13, 2020

Conversation

kakkoyun
Copy link
Member

This PR fixes the error we get from make jsonnet-fmt:

➜ make jsonnet-format
/bin/sh: -c: line 1: syntax error: unexpected end of file
make: *** [jsonnet-format] Error 2

Signed-off-by: Kemal Akkoyun [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Fix make task.

Verification

  • make jsonnet-format
  • make jsonnet-format-in-container

@kakkoyun
Fix broken make task
0be33df 
Signed-off-by: Kemal Akkoyun <[email protected]>
@kakkoyun
Copy link
Member Author

cc @brancz

@brancz brancz merged commit 5e87722 into thanos-io:master Feb 13, 2020
@kakkoyun kakkoyun deleted the fix_jsonnet_make branch February 13, 2020 13:34
@daixiang0 daixiang0 mentioned this pull request Feb 17, 2020
Closed
vankop pushed a commit to monitoring-tools/thanos that referenced this pull request Feb 28, 2020
@kakkoyun @vankop
Fix broken make task (thanos-io#2132)
3aeae83 
Signed-off-by: Kemal Akkoyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brancz brancz brancz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kakkoyun @brancz