Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a placeholder for devdocs #2695

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Add a placeholder for devdocs #2695

merged 2 commits into from
Jun 3, 2020

Conversation

yashrsharma44
Copy link
Contributor

Signed-off-by: Yash [email protected]

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

This PR adds a placeholder for writing up a dev-docs from scratch. Some content has been written up here in a doc

Verification

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, LGTM just small nits. 🤗

docs/contributing/onboarding-dev.md Outdated Show resolved Hide resolved
docs/contributing/onboarding-dev.md Show resolved Hide resolved
docs/contributing/onboarding-dev.md Show resolved Hide resolved
Signed-off-by: Yash <[email protected]>
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, amazing start 👍

@bwplotka bwplotka merged commit 65ce601 into thanos-io:master Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants