Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/gate: Refactor gate to enable to track metrics for multiple gates #2756

Merged
merged 1 commit into from
Jun 15, 2020
Merged

pkg/gate: Refactor gate to enable to track metrics for multiple gates #2756

merged 1 commit into from
Jun 15, 2020

Conversation

kakkoyun
Copy link
Member

Signed-off-by: Kemal Akkoyun [email protected]

Changes will be useful for #2657 to track gate metrics for queries that has multiple selects.

  • Change is not relevant to the end user.

Changes

  • Refactor gate to enable to track metrics for multiple gates
  • Add an interface that conforms prometheus/gate as well to use interchangeably

Verification

  • make test

@kakkoyun kakkoyun changed the title Refactor gate to enable to track metrics for multiple gates pkg/gate: Refactor gate to enable to track metrics for multiple gates Jun 12, 2020
@kakkoyun
Copy link
Member Author

Another flaky test incident, tests need a re-run.

pracucci
pracucci approved these changes Jun 12, 2020
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Changes LGTM (just left a nit about a comment).

pkg/gate/gate.go Outdated Show resolved Hide resolved
@kakkoyun kakkoyun requested a review from pracucci June 15, 2020 08:57
pracucci
pracucci approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👏

bwplotka
bwplotka approved these changes Jun 15, 2020
View reviewed changes
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤙 🤙

LGTM! Thanks All 👍

@bwplotka bwplotka merged commit 13afbee into thanos-io:master Jun 15, 2020
@kakkoyun kakkoyun deleted the gate branch June 16, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bwplotka bwplotka bwplotka approved these changes

@pracucci pracucci pracucci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kakkoyun @pracucci @bwplotka