chore: enable Swift CI tests #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FUSAKLA
force-pushed
the
fus-swift-ci-tests
branch
6 times, most recently
from
1e20edd to
b97fca7
Compare
Signed-off-by: Martin Chodur <[email protected]>
FUSAKLA
force-pushed
the
fus-swift-ci-tests
branch
from
b97fca7 to
158b13d
Compare
|
@GiedriusS PTAL |
2 tasks
bwplotka
approved these changes
Jul 6, 2020
Co-authored-by: Bartlomiej Plotka <[email protected]> Signed-off-by: Giedrius Statkevičius <[email protected]>
GiedriusS
force-pushed
the
fus-swift-ci-tests
branch
from
8995cd2 to
f4d32ac
Compare
|
Flaky test, rerun |
GiedriusS
added a commit
to GiedriusS/thanos
that referenced
this pull request
Jul 7, 2020
Added by thanos-io#2838. Signed-off-by: Giedrius Statkevičius <[email protected]>
|
Sorry for the lag I was on vacation. Thanks for fixing the typo and merging! :) |
GiedriusS
added a commit
that referenced
this pull request
Jul 8, 2020
Added by #2838. Signed-off-by: Giedrius Statkevičius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Martin Chodur [email protected]
Added Swift CI tests as suggested in #2829
I'm not sure if it should run for every test? I'm not sure if we are somehow limited in the CircleCI usage.
From time perspective it does not significantly prolong the test stage in CI.