Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: Added thanos bucket tool mark #3415

Merged
merged 3 commits into from
Nov 12, 2020
Merged

tools: Added thanos bucket tool mark #3415

merged 3 commits into from
Nov 12, 2020

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Nov 5, 2020

Signed-off-by: Bartlomiej Plotka [email protected]

GiedriusS
GiedriusS approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

cmd/thanos/tools_bucket.go Show resolved Hide resolved
yeya24
yeya24 approved these changes Nov 5, 2020
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good!

cmd/thanos/tools_bucket.go Show resolved Hide resolved
cmd/thanos/tools_bucket.go Outdated Show resolved Hide resolved
@bwplotka
Copy link
Member Author

bwplotka commented Nov 9, 2020

This PR is still blocked on #3410

@bwplotka
tools: Added thanos bucket tool mark
2718d41 
Signed-off-by: Bartlomiej Plotka <[email protected]>
@bwplotka
Rebase.
2ad1048 
Signed-off-by: Bartlomiej Plotka <[email protected]>
@bwplotka
Copy link
Member Author

bwplotka commented Nov 9, 2020

All fixed, should be good to go.

@yeya24
Copy link
Contributor

yeya24 commented Nov 11, 2020

Can u please fix the building error? Then it is good to go 🥇

@bwplotka
Fixed build errors.
b8cf1ae 
Signed-off-by: Bartlomiej Plotka <[email protected]>
@bwplotka bwplotka merged commit 69a045a into master Nov 12, 2020
@bwplotka bwplotka deleted the bucket-tool-mark branch November 12, 2020 14:59
Oghenebrume50 pushed a commit to Oghenebrume50/thanos that referenced this pull request Dec 7, 2020
@bwplotka @Oghenebrume50
tools: Added thanos bucket tool mark (thanos-io#3415)
91445bb 
* tools: Added thanos bucket tool mark

Signed-off-by: Bartlomiej Plotka <[email protected]>

* Rebase.

Signed-off-by: Bartlomiej Plotka <[email protected]>

* Fixed build errors.

Signed-off-by: Bartlomiej Plotka <[email protected]>
Signed-off-by: Oghenebrume50 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeya24 yeya24 yeya24 approved these changes

@GiedriusS GiedriusS GiedriusS approved these changes

@kakkoyun kakkoyun Awaiting requested review from kakkoyun

@squat squat Awaiting requested review from squat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bwplotka @yeya24 @GiedriusS