fix(docs): Fix two typos in design.md #3445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
approved these changes
Nov 14, 2020
| @@ -138,7 +138,7 @@ The compactor also does additional batch processing such as down-sampling and ap | |||
|
|
|||
| ## Scaling | |||
|
|
|||
| None of the Thanos components provides any means of sharding. The only explicitly scalable component are query nodes, which are stateless and can be scaled up arbitrarily. Scaling of storage capacity is ensured by relying on an external object storage system. | |||
| None of the Thanos components provides any means of sharding. The only explicitly scalable component are query nodes, which are stateless and can be scaled out arbitrarily. Scaling of storage capacity is ensured by relying on an external object storage system. | |||
There was a problem hiding this comment.
None of the Thanos components provides any means of sharding.
Wow, this does not hold truth anymore ;p
I think at this point we need to rename it as Initial Design? (:
cc @brancz
What's DCO? |
Signed-off-by: haslersn <[email protected]>
haslersn
force-pushed
the
fix-docs-design-typo
branch
from
6c75826 to
0067d04
Compare
bwplotka
approved these changes
Nov 16, 2020
Oghenebrume50
pushed a commit
to Oghenebrume50/thanos
that referenced
this pull request
Dec 7, 2020
Signed-off-by: haslersn <[email protected]> Signed-off-by: Oghenebrume50 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes