Split build/publish in CircleCI #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Split the test, build, and publish steps with CircleCI workflows. * Fixup `promu` target so it can be used outside of make. * Update git ignore list for promu use. * Update promu crossbuild list to avoid 32-bit builds. * Siplify publish step with workflow filter. Signed-off-by: Ben Kochie <[email protected]>
|
Huh, I have no idea why CircleCI is not reporting OK when both sub-tasks pass. |
bwplotka
approved these changes
Jul 2, 2018
| @echo ">> fetching promu" | ||
| @go get -u github.com/prometheus/promu | ||
| GOOS= GOARCH= go get -u github.com/prometheus/promu |
There was a problem hiding this comment.
This allows for setting GOOS and GOARCH locally for using cross-compile with make build. while still keeping the promu dependency locally compiled.
|
but still our CI is waiting forever.. wonder why |
|
Works now - wiIl merge, just have one question (asked above) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
promutarget so it can be used outside of make.Verification
Tested promu crossbuild locally.